Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant exception from Geometry.regexSensitiveDetector #1315

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix constant exception from Geometry.regexSensitiveDetector #1315

merged 1 commit into from
Aug 15, 2024
+2 −1

Conversation

SanghyunKo
Copy link
Contributor

@SanghyunKo SanghyunKo commented Aug 15, 2024 •
edited by andresailer
Loading

BEGINRELEASENOTES

  • DDSim: prevent Geometry.regexSensitiveDetector from always throwing exception when called with argument.

ENDRELEASENOTES

Fixing a (likely) typo from PR #1308, otherwise the DDSim interface always throws a Runtime error.
(sorry that I didn't catch this earlier)

@andresailer andresailer changed the title Fix typo from PR #1308 Fix constant exception from Geometry.regexSensitiveDetector Aug 15, 2024
@andresailer
Copy link
Member

Thanks! Bit more than a typo :/

@andresailer andresailer enabled auto-merge (rebase) August 15, 2024 09:32
@github-actions GitHub Actions
Copy link

Test Results

   14 files     14 suites   7h 47m 16s ⏱️
  365 tests   344 ✅ 0 💤 21 ❌
2 510 runs  2 465 ✅ 0 💤 45 ❌

For more details on these failures, see this check.

Results for commit 3111f61.

@andresailer andresailer merged commit e1017e3 into AIDASoft:master Aug 15, 2024
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanghyunKo @andresailer